Remove IcuTokenizer from TokenFilterDefinition variants union
#2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
) (cherry picked from commit a7be1d3)
Anaethelion
added a commit
that referenced
this pull request
Feb 23, 2024
) (#2417) (cherry picked from commit a7be1d3) Co-authored-by: Florian Bernd <[email protected]> Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IcuTokenizerwas accidentally added to theTokenFilterDefinitionvariants union a while ago. This PR removes the variant.This as well removes a special case where
IcuTokenizeris a variant of both,TokenizerandTokenFilterDefinitionand might allow for simplification of the code generators. cc @elastic/clients-team