-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch from java issues #2412
Batch from java issues #2412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2412-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d792c326a393769cc783482cf209435750d45029
# Push it to GitHub
git push --set-upstream origin backport-2412-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
* added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * adding custom options to index settings similarity (issue #299) * initial_master_nodes from string to string[] (issue #242) * correct contrib * correct node info discover class (issue #242)
* Batch from java issues (#2412) * added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * adding custom options to index settings similarity (issue #299) * initial_master_nodes from string to string[] (issue #242) * correct contrib * correct node info discover class (issue #242) * contrib
Fixes provided in this PR:
remove_binary
to AttachmentProcessorseed_hosts
optional to make the method.nodes().info()
work properly, also madeinitial_master_nodes
a string array, since the documentation allows for both a single string and an array, also added additional properties for NodeInfoDiscover