Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script definition in processorcontainer #2400

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

l-trotta
Copy link
Contributor

Fixes Issue 500
ProcessorContainer class was referring to Script instead of ScriptProcessor

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_pipeline 🟢 11/11 11/11
ingest.geo_ip_stats Missing test Missing test
ingest.get_pipeline 🔴 22/22 6/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_pipeline 🔴 33/42 40/42
ingest.simulate 🔴 0/7 6/7

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@l-trotta l-trotta merged commit 891d3cf into main Jan 29, 2024
9 checks passed
@l-trotta l-trotta deleted the script-processor-fix branch January 29, 2024 13:36
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2400-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 891d3cff9022b9726209cb7dcfd116c48b5669f6
# Push it to GitHub
git push --set-upstream origin backport-2400-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2400-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script Processor's Builder class does not support most parameters.
2 participants