Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reroute processor to ProcessorContainer #2392

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Jan 17, 2024

Adding the reroute processor to the processor types

@pquentin pquentin requested a review from a team January 17, 2024 14:31
@kgeller kgeller marked this pull request as ready for review January 17, 2024 14:42
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit for missing link to documentation, otherwise LGTM.

specification/ingest/_types/Processors.ts Show resolved Hide resolved
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_pipeline 🟢 11/11 11/11
ingest.geo_ip_stats Missing test Missing test
ingest.get_pipeline 🔴 22/22 6/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_pipeline 🔴 33/42 40/42
ingest.simulate 🔴 0/7 6/7

You can validate these APIs yourself by using the make validate target.

@kgeller kgeller requested a review from Anaethelion January 17, 2024 16:02
@Anaethelion Anaethelion merged commit a24aaab into main Jan 17, 2024
7 checks passed
@Anaethelion Anaethelion deleted the add-reroute-processor-ingest branch January 17, 2024 16:05
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
* Adding reroute processor to ProcessorContainer

* docs link added

(cherry picked from commit a24aaab)
Anaethelion pushed a commit that referenced this pull request Jan 17, 2024
* Adding reroute processor to ProcessorContainer

* docs link added

(cherry picked from commit a24aaab)

Co-authored-by: Kylie Meli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants