Update total property of HitsMetadata #2378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation, and my experience working with Elasticsearch at runtime, indicate that this property is never of type `long` and is always of type `TotalHits` (if it is defined). It would be nice if this was reflected in the types!
|
Hello, and sorry for the late reply! After being confused for a while by the worse validation results in #2626, I found that this is controlled by the Thank you for your contribution, I appreciate that you took the time to submit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation, and my experience working with Elasticsearch at runtime, indicate that this property is never of type
longand is always of typeTotalHits(if it is defined). It would be nice if this was reflected in the types!Maybe there's a reason this change is inappropriate (I don't know how this type might be used internally), but it was simple enough that fixing it seemed easier for everyone than writing an issue.
Thank you for considering this change!