-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added note for known typo #2369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
swallez
reviewed
Dec 12, 2023
swallez
reviewed
Dec 13, 2023
l-trotta
force-pushed
the
managed-by-lowercase-special-case
branch
from
December 13, 2023 10:28
27603fe
to
ef8672e
Compare
l-trotta
force-pushed
the
managed-by-lowercase-special-case
branch
from
December 13, 2023 10:31
ef8672e
to
f492ae8
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
swallez
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ManagedBy
enum has a field,Data stream lifecycle
, which should have been written likeData Stream Lifecycle
.This is not correct, but it's already part of the API and there are special cases for it in tests, so this PR adds a comment to notify future contributors of this anomaly.