Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Synonyms API as stable #2366

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Mark Synonyms API as stable #2366

merged 1 commit into from
Dec 14, 2023

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Dec 8, 2023

No description provided.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule Missing test Missing test
synonyms.delete_synonym Missing test Missing test
synonyms.get_synonym_rule Missing test Missing test
synonyms.get_synonym Missing test Missing test
synonyms.get_synonyms_sets Missing test Missing test
synonyms.put_synonym_rule Missing test Missing test
synonyms.put_synonym Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@kderusso kderusso marked this pull request as ready for review December 11, 2023 20:23
@kderusso kderusso requested a review from a team as a code owner December 11, 2023 20:23
Copy link

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In what version do they become stable? (Wondering if this should be backported to the 8.12 branch.)

@kderusso
Copy link
Member Author

Thanks! In what version do they become stable? (Wondering if this should be backported to the 8.12 branch.)
@pquentin This is planned for 8.13! Thanks for asking!

@pquentin pquentin merged commit c9a3d56 into main Dec 14, 2023
6 checks passed
@pquentin pquentin deleted the kderusso/synonyms-ga branch December 14, 2023 05:39
@codebrain
Copy link
Contributor

codebrain commented Feb 12, 2024

Thanks! In what version do they become stable? (Wondering if this should be backported to the 8.12 branch.)

Marked as public in 8.10:
https://github.com/elastic/elasticsearch/pull/97962/files

Marked as stable in 8.13:
elastic/elasticsearch#103223

Please ensure online docs are updated too as they are showing the API is in beta (which is incorrect):
image

@pquentin
Copy link
Member

The docs built from the main branch (that will become 8.13) are already correct: https://www.elastic.co/guide/en/elasticsearch/reference/master/synonyms-apis.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants