Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 8.10] Update deployment_id in ML trained model deployment start request #2335

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 6, 2023

Backport e627f16 from #2325.

…2325)

This adds the missing `deployment_id` query parameter to the `_start` request, that was introduced in v8.8.0.

[Docs](https://www.elastic.co/guide/en/elasticsearch/reference/8.8/start-trained-model-deployment.html#start-trained-model-deployment-query-params) say:

> deployment_id
> (Optional, string) A unique identifier for the deployment of the model.

(cherry picked from commit e627f16)
@github-actions github-actions bot requested review from a team as code owners November 6, 2023 16:10
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit d31cd4c into 8.10 Nov 15, 2023
1 check passed
@davidkyle davidkyle deleted the backport-2325-to-8.10 branch November 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants