Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler-rs lint warnings #2318

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix compiler-rs lint warnings #2318

merged 3 commits into from
Oct 26, 2023

Conversation

swallez
Copy link
Member

@swallez swallez commented Oct 26, 2023

This PR:

  • fixes warnings reported by the clippy linter.
  • adds the .d.ts files that were previously omitted because of .gitignore rules
  • updates the wasm module file
  • updates codeowners and labeler config for the new compiler-rs directory

@swallez swallez requested a review from Anaethelion October 26, 2023 12:59
@swallez swallez requested a review from a team as a code owner October 26, 2023 12:59
@swallez swallez merged commit 37fb1f5 into main Oct 26, 2023
6 checks passed
@swallez swallez deleted the compiler-rs-cleanup branch October 26, 2023 15:00
pquentin
pquentin reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin left review comments

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees
No one assigned
Labels
compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swallez @pquentin @Anaethelion