Address review comments

elastic · Apr 9, 2024 · c07ed5e · c07ed5e
1 parent 7a668f4
commit c07ed5e
Show file tree

Hide file tree

Showing 5 changed files with 58 additions and 88 deletions.
diff --git a/output/openapi/elasticsearch-serverless-openapi.json b/output/openapi/elasticsearch-serverless-openapi.json
diff --git a/output/schema/schema.json b/output/schema/schema.json
diff --git a/output/schema/validation-errors.json b/output/schema/validation-errors.json
diff --git a/output/typescript/types.ts b/output/typescript/types.ts
diff --git a/specification/_types/Knn.ts b/specification/_types/Knn.ts
@@ -19,7 +19,7 @@
 
 import { Field } from '@_types/common'
 import { long, float } from '@_types/Numeric'
-import { QueryContainer } from './query_dsl/abstractions'
+import { QueryBase, QueryContainer } from './query_dsl/abstractions'
 import { InnerHits } from '@global/search/_types/hits'
 
 export type QueryVector = float[]
@@ -51,28 +51,21 @@ export interface KnnSearch {
   inner_hits?: InnerHits
 }
 
-export interface KnnQuery {
+export interface KnnQuery extends QueryBase {
   /** The name of the vector field to search against */
   field: Field
   /** The query vector */
   query_vector?: QueryVector
   /** The query vector builder. You must provide a query_vector_builder or query_vector, but not both. */
   query_vector_builder?: QueryVectorBuilder
-  /** The final number of nearest neighbors to return as top hits */
-  k: long
   /** The number of nearest neighbor candidates to consider per shard */
-  num_candidates: long
+  num_candidates?: long
   /** Boost value to apply to kNN scores */
   boost?: float
   /** Filters for the kNN search query */
   filter?: QueryContainer | QueryContainer[]
   /** The minimum similarity for a vector to be considered a match */
   similarity?: float
-  /**
-   * If defined, each search hit will contain inner hits.
-   * @doc_id knn-inner-hits
-   */
-  inner_hits?: InnerHits
 }
 
 /** @variants container */