Address review requests

elastic · Dec 17, 2024 · 3f227c0 · 3f227c0
1 parent 726998b
commit 3f227c0
Show file tree

Hide file tree

Showing 6 changed files with 150 additions and 3 deletions.
diff --git a/output/openapi/elasticsearch-openapi.json b/output/openapi/elasticsearch-openapi.json
diff --git a/output/schema/schema.json b/output/schema/schema.json
diff --git a/output/schema/validation-errors.json b/output/schema/validation-errors.json
@@ -89,6 +89,20 @@
       ],
       "response": []
     },
+    "cat.segments": {
+      "request": [
+        "Request: query parameter 'local' does not exist in the json spec",
+        "Request: query parameter 'master_timeout' does not exist in the json spec"
+      ],
+      "response": []
+    },
+    "cat.tasks": {
+      "request": [
+        "Request: query parameter 'timeout' does not exist in the json spec",
+        "Request: query parameter 'wait_for_completion' does not exist in the json spec"
+      ],
+      "response": []
+    },
     "cat.transforms": {
       "request": [
         "request definition cat.transforms:Request / query - Property 'h' is already defined in an ancestor class",

diff --git a/output/typescript/types.ts b/output/typescript/types.ts
diff --git a/specification/cat/segments/CatSegmentsRequest.ts b/specification/cat/segments/CatSegmentsRequest.ts
@@ -19,6 +19,7 @@
 
 import { CatRequestBase } from '@cat/_types/CatBase'
 import { Bytes, Indices } from '@_types/common'
+import { Duration } from '@_types/Time'
 
 /**
  * Get segment information.
@@ -46,5 +47,18 @@ export interface Request extends CatRequestBase {
      * The unit used to display byte values.
      */
     bytes?: Bytes
+    /**
+     * If `true`, the request computes the list of selected nodes from the
+     * local cluster state. If `false` the list of selected nodes are computed
+     * from the cluster state of the master node. In both cases the coordinating
+     * node will send requests for further information to each selected node.
+     * @server_default false
+     */
+    local?: boolean
+    /**
+     * Period to wait for a connection to the master node.
+     * @server_default 30s
+     */
+    master_timeout?: Duration
   }
 }
diff --git a/specification/cat/tasks/CatTasksRequest.ts b/specification/cat/tasks/CatTasksRequest.ts
@@ -18,7 +18,7 @@
  */
 
 import { CatRequestBase } from '@cat/_types/CatBase'
-import { TimeUnit } from '@_types/Time'
+import { Duration, TimeUnit } from '@_types/Time'
 
 /**
  * Get task information.
@@ -49,5 +49,16 @@ export interface Request extends CatRequestBase {
      * Unit used to display time values.
      */
     time?: TimeUnit
+    /**
+     * Period to wait for a response.
+     * If no response is received before the timeout expires, the request fails and returns an error.
+     * @server_default 30s
+     */
+    timeout?: Duration
+    /**
+     * If `true`, the request blocks until the task has completed.
+     * @server_default false
+     */
+    wait_for_completion?: boolean
   }
 }