Skip to content

Commit

Permalink
Revert "Allow single fields in fields and _source parameters (#2317)" (
Browse files Browse the repository at this point in the history
…#2341)

This reverts commit 9f40be8.
  • Loading branch information
pquentin authored Nov 7, 2023
1 parent e627f16 commit 3893113
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 129 deletions.
39 changes: 4 additions & 35 deletions output/openapi/elasticsearch-serverless-openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -26307,14 +26307,7 @@
"description": "Array of wildcard (`*`) patterns.\nThe request returns doc values for field names matching these patterns in the `hits.fields` property of the response.",
"type": "array",
"items": {
"oneOf": [
{
"$ref": "#/components/schemas/_types:Field"
},
{
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
]
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
},
"knn": {
Expand Down Expand Up @@ -26389,14 +26382,7 @@
"description": "Array of wildcard (`*`) patterns.\nThe request returns values for field names matching these patterns in the `hits.fields` property of the response.",
"type": "array",
"items": {
"oneOf": [
{
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
},
{
"$ref": "#/components/schemas/_types:Field"
}
]
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
},
"suggest": {
Expand Down Expand Up @@ -34082,9 +34068,6 @@
{
"type": "boolean"
},
{
"$ref": "#/components/schemas/_types:Fields"
},
{
"$ref": "#/components/schemas/_global.search._types:SourceFilter"
}
Expand Down Expand Up @@ -54996,14 +54979,7 @@
"description": "Array of wildcard (*) patterns. The request returns doc values for field\nnames matching these patterns in the hits.fields property of the response.",
"type": "array",
"items": {
"oneOf": [
{
"$ref": "#/components/schemas/_types:Field"
},
{
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
]
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
},
"knn": {
Expand Down Expand Up @@ -55084,14 +55060,7 @@
"description": "Array of wildcard (*) patterns. The request returns values for field names\nmatching these patterns in the hits.fields property of the response.",
"type": "array",
"items": {
"oneOf": [
{
"$ref": "#/components/schemas/_types:Field"
},
{
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
]
"$ref": "#/components/schemas/_types.query_dsl:FieldAndFormat"
}
},
"terminate_after": {
Expand Down
108 changes: 26 additions & 82 deletions output/schema/schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions output/typescript/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions specification/_global/msearch/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { Dictionary } from '@spec_utils/Dictionary'
import { AggregationContainer } from '@_types/aggregations/AggregationContainer'
import {
ExpandWildcards,
Field,
Fields,
IndexName,
Indices,
Expand Down Expand Up @@ -97,7 +96,7 @@ export class MultisearchBody {
* Array of wildcard (*) patterns. The request returns doc values for field
* names matching these patterns in the hits.fields property of the response.
*/
docvalue_fields?: Array<Field | FieldAndFormat>
docvalue_fields?: FieldAndFormat[]
/**
* Defines the approximate kNN search to run.
* @availability stack since=8.4.0
Expand Down Expand Up @@ -147,7 +146,7 @@ export class MultisearchBody {
* Array of wildcard (*) patterns. The request returns values for field names
* matching these patterns in the hits.fields property of the response.
*/
fields?: Array<Field | FieldAndFormat>
fields?: Array<FieldAndFormat>
/**
* Maximum number of documents to collect for each shard. If a query reaches this
* limit, Elasticsearch terminates the query early. Elasticsearch collects documents
Expand Down
4 changes: 2 additions & 2 deletions specification/_global/search/SearchRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ export interface Request extends RequestBase {
* Array of wildcard (`*`) patterns.
* The request returns doc values for field names matching these patterns in the `hits.fields` property of the response.
*/
docvalue_fields?: Array<Field | FieldAndFormat>
docvalue_fields?: FieldAndFormat[]
/**
* Defines the approximate kNN search to run.
* @availability stack since=8.4.0
Expand Down Expand Up @@ -442,7 +442,7 @@ export interface Request extends RequestBase {
* Array of wildcard (`*`) patterns.
* The request returns values for field names matching these patterns in the `hits.fields` property of the response.
*/
fields?: Array<FieldAndFormat | Field>
fields?: Array<FieldAndFormat>
/**
* Defines a suggester that provides similar looking terms based on a provided text.
*/
Expand Down
4 changes: 2 additions & 2 deletions specification/_global/search/_types/SourceFilter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export class SourceFilter {

/**
* Defines how to fetch a source. Fetching can be disabled entirely, or the source can be filtered.
* @codegen_names fetch, fields, filter
* @codegen_names fetch, filter
*/
export type SourceConfig = boolean | Fields | SourceFilter
export type SourceConfig = boolean | SourceFilter

/**
* Defines how to fetch a source. Fetching can be disabled entirely, or the source can be filtered.
Expand Down

0 comments on commit 3893113

Please sign in to comment.