-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorstore: use a retriever query for hybrid search #2666
Vectorstore: use a retriever query for hybrid search #2666
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
711892a
to
1ba167a
Compare
1ba167a
to
203f678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this looks good, can you please explain why we can no longer disable RRF with AsyncDenseVectorStrategy(..., rrf=False)
? Should we change the annotation of that rrf
parameter from Union[bool, Dict[str, Any]]
to Dict[str, Any]
?
I did not consider the case of I'm not sure what would be the expected response when having hybrid search enabled and RRF disabled. Does that even make sense? I guess I need to try it out to see what response I get. |
} | ||
|
||
if self.rrf is False: | ||
query_body = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With rrf=False
we have to use a standard query, since the retriever query can only combine results from multiple searches with RRF.
e675035
to
b9bf952
Compare
@pquentin Okay, new revision of this fix. When the user asks for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Fixes #2651