-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use request converter to generate python examples #2643
use request converter to generate python examples #2643
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
76a498b
to
f993de2
Compare
f993de2
to
9e67739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
* use request converter to generate examples * updated examples * use correct license (cherry picked from commit 4ee4650)
) * use request converter to generate python examples (#2643) * use request converter to generate examples * updated examples * use correct license (cherry picked from commit 4ee4650) * update connector API documentation examples --------- Co-authored-by: Miguel Grinberg <[email protected]>
This PR replaces the
generate-examples.py
script with a new version written in JavaScript (heavily based on the JS client's example generator) that uses the request converter library.