Fix type annotation of source parameter. #2347
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be completely wrong, but I think the type hinting of the
source
parameter forElasticsearch().search()
should beSequence[str]
and notMapping[str, Any]
(s. https://www.elastic.co/guide/en/elasticsearch/reference/current/search-fields.html#source-filtering)Also
fields
should be acceptingstr
as well asMapping[str, Any]