Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] Fix mypy error #2244

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[8.9] Fix mypy error #2244

merged 2 commits into from
Sep 12, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 5, 2023 •
edited
Loading

I noticed this while looking at #2243.

Are you open to pin the versions of black, mypy and other linters?

  • black is now stable but it releases a breaking version every year.
  • mypy reached 1.0 but continues to improve rapidly which means type: ignore statements turn into error with each new release.

@pquentin pquentin requested a review from JoshMock July 5, 2023 06:15
JoshMock
JoshMock approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why I never approved this 😄

@pquentin pquentin merged commit 5561460 into elastic:main Sep 12, 2023
14 checks passed
@pquentin pquentin deleted the 8.9-lint branch September 12, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @JoshMock