Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded @types/node package to v18 #2374

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Upgraded @types/node package to v18 #2374

merged 1 commit into from
Oct 14, 2024

Conversation

miguelgrinberg
Copy link
Contributor

@miguelgrinberg miguelgrinberg commented Oct 14, 2024

Trying to build the client started to return errors after a recent update of the undici package. Updating from the v17 of @types/node to v18 appears to address the issue.

This is the what I'm getting as output with the v17 package:

> tsc && rm lib/package.json && mv lib/src/* lib/ && rm -rf lib/src

node_modules/undici/types/eventsource.d.ts:13:9 - error TS2304: Cannot find name 'Event'.

13   open: Event
           ~~~~~

node_modules/undici/types/eventsource.d.ts:16:31 - error TS2304: Cannot find name 'EventTarget'.

16 interface EventSource extends EventTarget {
                                 ~~~~~~~~~~~

node_modules/undici/types/eventsource.d.ts:23:35 - error TS2304: Cannot find name 'Event'.

23   onopen: (this: EventSource, ev: Event) => any
                                     ~~~~~

node_modules/undici/types/filereader.d.ts:7:14 - error TS2304: Cannot find name 'EventTarget'.

7   __proto__: EventTarget & FileReader
               ~~~~~~~~~~~

node_modules/undici/types/filereader.d.ts:47:14 - error TS2304: Cannot find name 'Event'.

47   __proto__: Event & ProgressEvent
                ~~~~~

node_modules/undici/types/patch.d.ts:28:24 - error TS2304: Cannot find name 'Event'.

28   handleEvent (object: Event): void
                          ~~~~~

node_modules/undici/types/patch.d.ts:32:9 - error TS2304: Cannot find name 'Event'.

32   (evt: Event): void
           ~~~~~

node_modules/undici/types/websocket.d.ts:20:9 - error TS2304: Cannot find name 'Event'.

20   open: Event
           ~~~~~

node_modules/undici/types/websocket.d.ts:23:29 - error TS2304: Cannot find name 'EventTarget'.

23 interface WebSocket extends EventTarget {
                               ~~~~~~~~~~~

node_modules/undici/types/websocket.d.ts:83:30 - error TS2304: Cannot find name 'Event'.

83 interface CloseEvent extends Event {
                                ~~~~~

node_modules/undici/types/websocket.d.ts:102:41 - error TS2304: Cannot find name 'Event'.

102 interface MessageEvent<T = any> extends Event {
                                            ~~~~~

node_modules/undici/types/websocket.d.ts:133:30 - error TS2304: Cannot find name 'Event'.

133 interface ErrorEvent extends Event {
                                 ~~~~~


Found 12 errors in 4 files.

Errors  Files
     3  node_modules/undici/types/eventsource.d.ts:13
     2  node_modules/undici/types/filereader.d.ts:7
     2  node_modules/undici/types/patch.d.ts:28
     5  node_modules/undici/types/websocket.d.ts:20

@JoshMock
Copy link
Member

Thanks for catching this! Now I'll have to figure out how many minor versions will need this change backported. 🫠

@JoshMock JoshMock merged commit c274b1b into main Oct 14, 2024
19 of 20 checks passed
@JoshMock JoshMock deleted the upgrade-types-node branch October 14, 2024 16:13
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants