-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop supporting Node v14 and v16 #2055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.11 8.11
# Navigate to the new working tree
cd .worktrees/backport-8.11
# Create a new branch
git switch --create backport-2055-to-8.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3c5178c7aebaf435f127de29d57298519c6ac85a
# Push it to GitHub
git push --set-upstream origin backport-2055-to-8.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.11 Then, create a pull request where the |
JoshMock
added a commit
that referenced
this pull request
Nov 2, 2023
JoshMock
added a commit
that referenced
this pull request
Nov 2, 2023
JoshMock
added
the
apply-to-serverless
Used by automation to generate a patch from a PR and apply it to elasticsearch-serverless-js
label
Mar 27, 2024
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jun 27, 2024
esclient v8.11.0's min support Node.js is v18 Refs: elastic/elasticsearch-js#2055
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jul 2, 2024
esclient v8.11.0's min support Node.js is v18 Refs: elastic/elasticsearch-js#2055
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jul 24, 2024
esclient v8.11.0's min support Node.js is v18 Refs: elastic/elasticsearch-js#2055
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…c#4110) esclient v8.11.0's min support Node.js is v18 Refs: elastic/elasticsearch-js#2055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apply-to-serverless
Used by automation to generate a patch from a PR and apply it to elasticsearch-serverless-js
backport 8.11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping official support for Node.js v14 and v18 as they are both EOL. This mostly just means not testing code against those versions, and updating the supported version in the package.json. But future versions may take advantage of JavaScript or Node.js features that are only available in v18+.
This will be released in client v8.11 in the next week or two.
Fixes #1855.