Fix version bump script (#2054)

* Fix version bump script failure It was trying to run `.replace` on a Buffer instead of a string. * Correctly set Node version in Docker
elastic · Nov 2, 2023 · 1adc8c3 · 1adc8c3
1 parent 2d139e5
commit 1adc8c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.ci/Dockerfile b/.ci/Dockerfile
@@ -1,4 +1,4 @@
-ARG NODE_JS_VERSION=18
+ARG NODE_JS_VERSION=${NODE_JS_VERSION:-18}
 FROM node:${NODE_JS_VERSION}
 
 ARG BUILDER_UID=1000

diff --git a/.ci/make.mjs b/.ci/make.mjs
@@ -86,10 +86,10 @@ async function bump (args) {
     'utf8'
   )
 
-  const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml'))
+  const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml'), 'utf8')
   await writeFile(
     join(import.meta.url, '..', '.buildkite', 'pipeline.yml'),
-    pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`), // eslint-disable-line
+    pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`),
     'utf8'
   )
 }