Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse ES|QL response body header more leniently #903

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Parse ES|QL response body header more leniently #903

merged 2 commits into from
Nov 14, 2024

Conversation

swallez
Copy link
Member

@swallez swallez commented Nov 13, 2024

A took property was added in ES 8.16, which caused EsqlAdapterBase.readHeader().

This PR fixes that, by handling took and also by ignoring unknown properties encountered before the values array.

@swallez swallez requested a review from l-trotta November 13, 2024 14:30
@dadoonet dadoonet mentioned this pull request Nov 14, 2024
Merged
dadoonet added a commit to dadoonet/elasticsearch-java-client-demo that referenced this pull request Nov 14, 2024
@dadoonet
Update tests while ES|QL parsing is fixed
eae5ae5 
See elastic/elasticsearch-java#903
l-trotta
l-trotta approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit d130ce5 into main Nov 14, 2024
7 checks passed
@l-trotta l-trotta deleted the fix-esql-adapter branch November 14, 2024 16:55
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
@swallez @l-trotta @github-actions
Parse ES|QL response body header more leniently (#903)
823b5d7 
Co-authored-by: Laura Trotta <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Merged
l-trotta added a commit that referenced this pull request Nov 18, 2024
@github-actions @swallez @l-trotta
Parse ES|QL response body header more leniently (#903) (#906)
da2d0d2 
Co-authored-by: Sylvain Wallez <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@swallez @l-trotta @github-actions
Parse ES|QL response body header more leniently (#903)
a0a4319 
Co-authored-by: Laura Trotta <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
l-trotta added a commit that referenced this pull request Nov 19, 2024
@github-actions @swallez @l-trotta
Parse ES|QL response body header more leniently (#903) (#911)
73edf7e 
Co-authored-by: Sylvain Wallez <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-trotta l-trotta l-trotta approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swallez @l-trotta