Fix ClassCastException in inferred spans (#249)

elastic · May 7, 2024 · 74c9170 · 74c9170
1 parent 76ccb1c
commit 74c9170
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/common/src/main/java/co/elastic/otel/common/LocalRootSpan.java b/common/src/main/java/co/elastic/otel/common/LocalRootSpan.java
@@ -108,10 +108,12 @@ public static ReadableSpan getFor(ReadableSpan span) {
    */
   @Nullable
   public static ReadableSpan getFor(Span span) {
-    if (span.getSpanContext().isRemote()) {
+    if (span instanceof ReadableSpan) {
+      return getFor((ReadableSpan) span);
+    } else {
+      // This can happen when invoked for a PropagatedSpan (e.g. Span.fromContext())
       return null;
     }
-    return getFor((ReadableSpan) span);
   }
 
   /** See {@link LocalRootSpan#getFor(Span)}. */

diff --git a/testing/integration-tests/inferred-spans-test/build.gradle.kts b/testing/integration-tests/inferred-spans-test/build.gradle.kts
@@ -11,6 +11,7 @@ dependencies {
 tasks.withType<Test>() {
   jvmArgs(
     //"-Dotel.javaagent.debug=true",
+    "-Dotel.service.name=testing",
     "-Delastic.otel.inferred.spans.enabled=true",
     "-Delastic.otel.inferred.spans.duration=2000ms",
     "-Delastic.otel.inferred.spans.interval=2000ms",