Fix typo in float format for APM_SAMPLING_RATE #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
pchila
force-pushed
the
fix-typo-in-strconv-FormatFloat
branch
from
f945788 to
d2092e0
Compare
pchila
force-pushed
the
fix-typo-in-strconv-FormatFloat
branch
from
d2092e0 to
3875bab
Compare
pierrehilbert
approved these changes
Oct 7, 2024
|
pkoutsovasilis
approved these changes
Oct 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fix float format for APM_SAMPLING_RATE (cherry picked from commit 862b044)
2 tasks
pchila
added a commit
that referenced
this pull request
Oct 7, 2024
* Fix float format for APM_SAMPLING_RATE (cherry picked from commit 862b044) Co-authored-by: Paolo Chilà <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix float format specification for APM_SAMPLING_RATE
Why is it important?
Agent will not start because apm.Tracer will error out when a badly formatted sampling rate is passed as environment variable
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself