Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip error.stack_trace if empty #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mosche
Copy link

@mosche mosche commented Jul 11, 2024

Opening this PR for discussion.

Some exceptions in Elasticsearch don't contain a stacktrace, e.g. NotMasterException.
For these error.stack_trace typically just repeats what's already present in error.type and error.message, having the field doesn't add any value.

Can we skip error.stack_trace in this case?

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage Issues and PRs that need to be triaged labels Jul 11, 2024
@JonasKunz
Copy link
Contributor

Hey @mosche , sorry for the delayed response.

For these error.stack_trace typically just repeats what's already present in error.type and error.message, having the field doesn't add any value

This feels like a very elasticsearch specific edge-case, therefore I'm not sure whether we want to add this.
I also think that in general this would lead to a worse user-experience: E.g. if one is filtering on specifically error.stack_trace to contain a word, those errors would suddenly not match the search anymore, which isn't intuitive without knowledge of this "feature".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage Issues and PRs that need to be triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants