-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(snapshot): skip deploy if no snapshot version or release version #238
Merged
JonasKunz
merged 7 commits into
elastic:main
from
v1v:fix/skip-snapshot-if-no-snapshot-version
Feb 20, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0cc7e1d
ci(snapshot): skip deploy if no snapshot version
v1v c5bbf5d
use functions
v1v 02558e7
install required tools
v1v 1ff22a6
avoid releases from snapshots
v1v 599c76b
Update .github/workflows/release.yml
v1v 46cb88e
Update .github/workflows/snapshot.yml
v1v a696105
checkout the given ref to validate whether it exists and the version …
v1v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ jobs: | |
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ inputs.ref }} | ||
fetch-depth: 0 | ||
- name: Validate tag does not exist on current commit | ||
uses: ./.github/workflows/validate-tag | ||
|
@@ -51,6 +52,12 @@ jobs: | |
echo "Tag should match pom.xml project.version" | ||
exit 1 | ||
fi | ||
- name: Validate version is a release version | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Otherwise, the |
||
run: | | ||
if [[ "$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout)" =~ "-SNAPSHOT" ]]; then | ||
SylvainJuge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
echo "This is a snapshot version" | ||
exit 1 | ||
fi | ||
|
||
release: | ||
name: Release | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail fast if the ref is not correct. Otherwise, it's required to wait for the Buildkite pipeline to run