Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new release process #226

Merged
merged 14 commits into from
Feb 2, 2024
Merged

feat: new release process #226

merged 14 commits into from
Feb 2, 2024

Conversation

amannocci
Copy link
Contributor

What is the change being made?

  • Implement a new release process compliant with security rules.

Why is the change being made?

  • The old release process isn't compliant with security rules and is broken.
  • The new release process is a two phased approach allowing commit review at any point.

Signed-off-by: Adrien Mannocci <[email protected]>
@amannocci amannocci requested review from SylvainJuge and a team January 29, 2024 17:14
@amannocci amannocci self-assigned this Jan 29, 2024
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.ci/release.sh Outdated Show resolved Hide resolved
.ci/release.sh Outdated Show resolved Hide resolved
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-relaese and release workflow have several things in common, so a composite action can help with removing the duplicated steps.

I miss a version validation in both workflows. So if by accident someone set an existing release as an input version, then it should fail with an error earlier.

.ci/snapshot.sh Outdated Show resolved Hide resolved
.github/workflows/prepare-release.yml Outdated Show resolved Hide resolved
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I'd like to see some validation if the version parameter points to an existing GitHub tag and fail if that's the case.

Do you think the existing documentation in https://github.com/elastic/ecs-logging-java/blob/main/CONTRIBUTING.md#releasing could be changed to reflect this set of changes?

.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
v1v
v1v previously approved these changes Jan 31, 2024
@amannocci amannocci requested a review from SylvainJuge January 31, 2024 15:35
.github/workflows/pre-post-release.yml Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-post-release.yml Outdated Show resolved Hide resolved
uses: ./.github/workflows/validate-tag
with:
tag: ${{ env.RELEASE_VERSION }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should probably do an extra verification step to ensure that the maven project version is the one we expect from the parameters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: 16f61a6

Signed-off-by: Adrien Mannocci <[email protected]>
@amannocci amannocci merged commit 537cd36 into main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants