Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable throwable serialization #105

Closed
wants to merge 2 commits into from
Closed

Configurable throwable serialization #105

wants to merge 2 commits into from

Conversation

HaloFour
Copy link
Contributor

Refactors the serialization of Throwable instances into an interface to allow formatter/layout projects to offer configuration options for how the exception is serialized.

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 11, 2020 •
edited
Loading

💚 CLA has been signed

@apmmachine
Copy link
Contributor

apmmachine commented Nov 11, 2020 •
edited
Loading

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-12-31T10:31:20.659+0000

  • Duration: 3 min 10 sec

  • Commit: 35f75ec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@felixbarny felixbarny linked an issue Nov 11, 2020 that may be closed by this pull request
Configuration for formatting Throwable stack traces #103
Open
@felixbarny
Copy link
Member

The approach looks really good!

@felixbarny felixbarny marked this pull request as draft November 12, 2020 15:59
@felixbarny felixbarny changed the title WIP: Configurable throwable serialization Configurable throwable serialization Nov 12, 2020
@HaloFour
Copy link
Contributor Author

I'm going to attempt to put some more effort into this PR in the next few weeks. I'm trying to reconcile whether it's worthwhile to have a consistent way to format the exception or if it's something that should be delegated to whatever logging library is being used, e.g. throwable patterns in log4j2.

@eyalkoren eyalkoren mentioned this pull request Apr 5, 2022
Merged
@HaloFour
Copy link
Contributor Author

HaloFour commented Apr 5, 2022

Closing in favor of #177

@HaloFour HaloFour closed this Apr 5, 2022
@HaloFour HaloFour deleted the configurable-throwable-serialization branch April 5, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration for formatting Throwable stack traces
4 participants
@HaloFour @apmmachine @felixbarny @AlexanderWert