-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust docs tooling for integration plugins #107
base: main
Are you sure you want to change the base?
Conversation
@jsvd @mashhurs Here's the proposed fix to docs-tools. Please check it out. @robbavey Will you please take a look at this to ensure that we're achieving your goals and not violating your design intent in #40?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if we merge this then we'll have to backport elastic/logstash#16174 (review) to all release threads still producing builds |
@karenzone Questions from Slack... What does this do for integration plugins that are in development, when we still want to preserve the originals? |
Once again, this is a case where the "plugin-stack version mismatch" bites us. For now, I am managing this manually by allowing in the new SNMP integration page v4.0.0 at Technical Preview in, and keeping the branch-appropriate versions of the stand-alone input-snmp and input-snmptrap. Obviously this is less than ideal, but it's the best I've come up with so far. Is there a way that we can make our plugins and our docs-tooling branch aware beyond gemlock files? |
Related:
Change to processing logic for integration plugins.
We have a situation in which we are moving an integration plugin into Technical Preview before we bundle it with Logstash by default. This means that we need the ability to generate integration plugin docs while the plugin status is
default-plugins: false
.We've prepared for this change by adding the two impacted plugins (
logstash-integration-internal
andlogstash-integration-zeromq
) to plugins-metadata.json, and setting their values todefault-plugins: false
and"skip-list": true
..