Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripted metrics to serverless differences #52

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Aug 23, 2024

Scripted metric aggregations are not available in Serverless. See also elastic/elasticsearch#112161

Previews:

@elasticdocs
Copy link
Collaborator

elasticdocs commented Aug 23, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@marciw marciw changed the title Update serverless-differences.mdx Add scripted metrics to serverless differences Aug 23, 2024
@marciw marciw requested review from nik9000 and shainaraskas August 23, 2024 19:58
nik9000
nik9000 previously approved these changes Aug 23, 2024
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@marciw
Copy link
Contributor Author

marciw commented Aug 23, 2024

Sounds good to me!

sorry, got a good suggestion after requesting reviews so jumped the gun there :)

@marciw marciw marked this pull request as ready for review August 23, 2024 20:30
@marciw marciw requested a review from a team as a code owner August 23, 2024 20:30
@marciw marciw requested a review from nik9000 August 23, 2024 20:52
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@marciw marciw merged commit 0ee363d into main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants