-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize files into a flat structure #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file was moved here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrectly detecting as a new file - caused by all of the widget files previously being identical.
Thanks! This is nice. I pulled it down and here are the first few things that crossed my minds (some of those are likely to be treated separately from this PR ^^'):
We can definitely merge like this, but it'd be great to think about some of these points fairly soon. |
Actually, building this PR locally, I noticed that the general docs are missing some files. It looks like an older version of the doc set. I don't see content added over the last couple of weeks. I'll try to locate an exact date. Edit: For content from staging-serverless-general-docs, it seems that this repo has everything up until commit Edit2: Fixed, thank you 🙏 |
hey @florent-leborgne! I've fixed the history issue (thank you!). In reply to your other comment:
This is definitely a concern. The partials are sitting in this
I agree with you that this looks pretty overwhelming. Part of the motivation in flattening the structure is to avoid assuming what is going to be grouped together/what mental models people will use in the future. @chriscressman has talked a lot about this, but an imperfect summary is that we want to assume that people won't be using the file name / repo folder structure to find content, but instead using some sort of file identifier to find it through search (or jump to the file using an "Edit this page" button like the one below). That being said, I think that naming conventions are a lightweight way to add context at a glance so that might be a good way forward in the interim. These don't map exactly to the old folders we had, so it would be a manual effort. Will think more about this.
Great callout. Was just talking to someone about how the slugs are essentially arbitrary. I think we need to define a pattern around this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR reorganizes our files into a flat structure, and updates xrefs so all images and partials load as intended.
Confirmed IA is the same + previewed images + partials to make sure they rendered.
The flat structure is intended to:
If we decide that this structure isn’t granular enough to navigate for our contributors, we can add additional subfolders later.
nb: the partials we currently have are only used in a single place. in my opinion, these could be integrated into the parent page.