Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom roles to organization management #40

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Add custom roles to organization management #40

merged 5 commits into from
Jul 4, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 3, 2024 •
edited
Loading

This PR:

NOTE: The information about the custom role feature will not be displayed until the "serverlessCustomRoles" feature flag is changed to "true" in a subsequent PR.

@lcawl lcawl marked this pull request as ready for review July 3, 2024 16:17
@lcawl lcawl requested a review from a team as a code owner July 3, 2024 16:17
@lcawl lcawl requested a review from jeramysoucy July 3, 2024 16:17
@elasticdocs
Copy link
Collaborator

elasticdocs commented Jul 3, 2024 •
edited
Loading

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

alxchalkias
alxchalkias reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@alxchalkias alxchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to make it clear that each custom role refers to a specific project

serverless/pages/manage-access-to-org-user-roles.mdx Outdated Show resolved Hide resolved
alxchalkias
alxchalkias approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@alxchalkias alxchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

kilfoyle
kilfoyle approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦕

@lcawl lcawl merged commit 87e122d into elastic:main Jul 4, 2024
2 checks passed
@lcawl lcawl deleted the custom-role-assignment branch July 4, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@alxchalkias alxchalkias alxchalkias approved these changes

@jeramysoucy jeramysoucy Awaiting requested review from jeramysoucy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @elasticdocs @alxchalkias @kilfoyle