Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high level serverless doc consolidation and refactoring #191

Merged
merged 37 commits into from
Dec 2, 2024
Merged

high level serverless doc consolidation and refactoring #191

merged 37 commits into from
Dec 2, 2024

Conversation

georgewallace
Copy link
Contributor

@georgewallace georgewallace commented Nov 13, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@georgewallace
Copy link
Contributor Author

georgewallace commented Nov 13, 2024 •
edited
Loading

This PR is related to #145, #144, #95, #69, #62, #102, #107, #64

@georgewallace
Copy link
Contributor Author

cc: @KOTungseth started refactor

@georgewallace georgewallace force-pushed the serverless_intro_update branch from 973621f to dd83f59 Compare November 18, 2024 15:48
florent-leborgne
florent-leborgne reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of suggestions to make the narrative clearer

serverless/index-serverless-project-settings.asciidoc Show resolved Hide resolved
serverless/index-serverless-project-settings.asciidoc Outdated Show resolved Hide resolved
serverless/index-serverless-project-settings.asciidoc Outdated Show resolved Hide resolved
serverless/index-serverless-project-settings.asciidoc Show resolved Hide resolved
serverless/index-serverless-project-settings.asciidoc Outdated Show resolved Hide resolved
serverless/pages/manage-org.asciidoc Outdated Show resolved Hide resolved
@georgewallace georgewallace force-pushed the serverless_intro_update branch from 85b1e97 to 30ae387 Compare November 19, 2024 15:24
@georgewallace
Copy link
Contributor Author

run docs-build

@georgewallace georgewallace marked this pull request as ready for review November 20, 2024 16:06
@georgewallace georgewallace requested a review from a team as a code owner November 20, 2024 16:06
@georgewallace georgewallace changed the title updating guidance for serverless overview high level serverless doc consolidation and refactoring Nov 20, 2024
timto-elastic
timto-elastic reviewed Nov 20, 2024
View reviewed changes
serverless/pages/manage-org.asciidoc Outdated
+
You can add multiple members by entering their email addresses separated by a space or pressing Enter.
+
You can grant access to all projects of the same type with a unique role, or select individual roles for specific projects.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the mappings from roles to projects in this sentence.

timto-elastic
timto-elastic reviewed Nov 20, 2024
View reviewed changes
serverless/pages/manage-org.asciidoc

[discrete]
[[general-assign-user-roles-instance-access-roles]]
=== Instance access roles
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does instance access mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Instance access" is the term used in the Roles UI to refer to "hosted deployment or serverless project".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave additional upfront guidance to clear up the confusion.

@georgewallace georgewallace force-pushed the serverless_intro_update branch from 57e7802 to 11bd5df Compare November 21, 2024 03:31
@leemthompo
Copy link
Contributor

Sorry for the noise, I didn't realize the visualize library page had been reintroduced, so reverted my commits :)

@georgewallace
Copy link
Contributor Author

run docs-build

@georgewallace georgewallace force-pushed the serverless_intro_update branch from 711fd41 to 1d70639 Compare November 22, 2024 14:39
@georgewallace georgewallace force-pushed the serverless_intro_update branch from cb9a4dc to b7718cb Compare November 22, 2024 21:22
KOTungseth
KOTungseth reviewed Nov 22, 2024
View reviewed changes
serverless/pages/manage-billing.asciidoc Outdated Show resolved Hide resolved
serverless/pages/sign-up.asciidoc Show resolved Hide resolved
serverless/pages/sign-up.asciidoc Outdated Show resolved Hide resolved
serverless/pages/sign-up.asciidoc Show resolved Hide resolved
serverless/pages/sign-up.asciidoc Outdated Show resolved Hide resolved
serverless/pages/manage-org.asciidoc Outdated Show resolved Hide resolved
serverless/pages/manage-org.asciidoc Outdated Show resolved Hide resolved
serverless/pages/manage-org.asciidoc Outdated Show resolved Hide resolved
serverless/pages/welcome-to-serverless.asciidoc Outdated Show resolved Hide resolved
serverless/index-serverless-general.asciidoc Outdated Show resolved Hide resolved
florent-leborgne
florent-leborgne reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small fixes in the latest edits

serverless/pages/sign-up.asciidoc Outdated Show resolved Hide resolved
serverless/pages/get-started-general.asciidoc Outdated Show resolved Hide resolved
serverless/pages/sign-up.asciidoc Outdated Show resolved Hide resolved
georgewallace and others added 2 commits November 25, 2024 08:03
kilfoyle
kilfoyle previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
I read through it and all looks good.

florent-leborgne
florent-leborgne previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes the structure a lot more natural to navigate

@georgewallace
Copy link
Contributor Author

Will merge once redirects in https://github.com/elastic/website-development/issues/14461 are live.

@georgewallace
Copy link
Contributor Author

run docs-build

@georgewallace
Copy link
Contributor Author

run docs-build

kilfoyle
kilfoyle approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Just a quick drive-by but I reviewed more carefully earlier.

@georgewallace georgewallace merged commit cd313b7 into elastic:main Dec 2, 2024
3 checks passed
@shainaraskas shainaraskas mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timto-elastic timto-elastic timto-elastic left review comments

@KOTungseth KOTungseth KOTungseth left review comments

@leemthompo leemthompo leemthompo left review comments

@kilfoyle kilfoyle kilfoyle approved these changes

@florent-leborgne florent-leborgne florent-leborgne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@georgewallace @leemthompo @florent-leborgne @KOTungseth @kilfoyle @timto-elastic