Fix collapsing toc when clicking on a nested page #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
reakaleek
commented
Jan 7, 2025
Comment on lines
+18
to
+41
| /** | ||
| * Expands all collapsed parent sections in the navigation tree that contain the current page link. | ||
| * This ensures the current page is visible in the navigation by opening all ancestor collapsible sections. | ||
| * The function works by: | ||
| * 1. Finding the navigation link matching the current page URL | ||
| * 2. Walking up the DOM tree from that link | ||
| * 3. Expanding any collapsed parent sections by toggling their CSS classes | ||
| */ | ||
| function expandCurrentPage() { | ||
| const currentPathname = window.location.pathname; | ||
| const currentLink = document.querySelector(`a[href="${currentPathname}"]`); | ||
| if (currentLink) { | ||
| let parent = currentLink.parentElement; | ||
| while (parent) { | ||
| if (parent.classList && parent.classList.contains('_collapse')) { | ||
| parent.classList.remove('_collapse'); | ||
| parent.classList.add('_expand'); | ||
| } | ||
| parent = parent.parentElement; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| expandCurrentPage(); |
There was a problem hiding this comment.
It seems like the GH UI does not render this due to its content.
Adding a comment here to see the diff.
Mpdreamz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Changes
Screen.Recording.2025-01-07.at.21.47.29.mov
Notes
This is a hacky fix since the source code for this functionality is minified and just copied here.
Doing this properly should be handled after the next major release.