Add Azure credentials type in configuration #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moukoublen
changed the title
moukoublen
changed the title
📊 Allure Report - 💚 No failures were reported.
|
orestisfl
reviewed
Nov 15, 2023
moukoublen
force-pushed
the
azure_credentials_type_switch
branch
from
476b412 to
436e75b
Compare
orestisfl
reviewed
Nov 15, 2023
| }, | ||
| }, | ||
| authProviderInitFn: initDefaultCredentialsMock(nil), | ||
| want: &AzureFactoryConfig{ |
There was a problem hiding this comment.
Sorry for being nitpicky but this should probably return an error, it signifies a mismatch between integration and cloubeat
There was a problem hiding this comment.
Sure, I added an error in that case. Not in an empty string, though. Empty string fallbacks to default.
moukoublen
force-pushed
the
azure_credentials_type_switch
branch
from
436e75b to
cfa0040
Compare
moukoublen
force-pushed
the
azure_credentials_type_switch
branch
from
4e23a54 to
f4ccfcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Based on the discussion in this comment, this PR adds the Azure credentials type in the config and uses it to identify which Azure
TokenCredentialto use.Enumerator values are on par with this PR.
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?