-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use optional values for docker memory metrics #41449
Use optional values for docker memory metrics #41449
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* use opt values for docker memory metrics * fix vars, comments * add changelog * spelling (cherry picked from commit 249d0dc)
Proposed commit message
Closes #40060
This deals with an issue where we were reporting docker memory
rss
metrics even though none exist under cgroups V2. This takes the easy way out by just changing the hashmaps to use option types, so we don't report0
values when none should exist.I'm not sure there's a better way to do this. As far as I can tell, there's no similar metrics in Docker's cgroups V2 reporting, and in my experience trying to be clever and derive a substitute value usually backfires for heterogeneous monitoring setups.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
In cases where the docker/memory metrics were reporting an invalid
0
, they will not not report any value at all.