Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winlogbeat] Add handling for missing event data types in the experimental API #41418

Merged
merged 11 commits into from
Nov 4, 2024
Merged

[winlogbeat] Add handling for missing event data types in the experimental API #41418

merged 11 commits into from
Nov 4, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 24, 2024

Proposed commit message

Adds handling for missing event data types in the experimental API

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This reopens #40684 but fixes the issue found at #41009

@marc-gr marc-gr added enhancement Winlogbeat Team:Security-Windows Platform Windows Platform Team in Security Solution backport-8.x Automated backport to the 8.x branch with mergify labels Oct 24, 2024
@marc-gr marc-gr requested a review from a team as a code owner October 24, 2024 08:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 24, 2024
@ycombinator ycombinator removed their request for review October 24, 2024 14:02
@ycombinator ycombinator added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 24, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@ycombinator ycombinator removed the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 24, 2024
@ycombinator ycombinator requested review from a team, faec, khushijain21 and leehinman and removed request for a team and khushijain21 October 24, 2024 14:02
leehinman
leehinman approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one question on if we need/want to maintain a custom BinaryToString. I'm ok with it either way.

winlogbeat/sys/strings.go Show resolved Hide resolved
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 24, 2024
andrewkroh
andrewkroh reviewed Oct 31, 2024
View reviewed changes
winlogbeat/sys/zsyscall_windows.go Outdated Show resolved Hide resolved
winlogbeat/sys/strings_windows.go Outdated Show resolved Hide resolved
@marc-gr marc-gr merged commit 36c3d5d into elastic:main Nov 4, 2024
26 of 28 checks passed
@marc-gr marc-gr deleted the feat/add-exp-types-fixed branch November 4, 2024 15:12
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@marc-gr @mergify
[winlogbeat] Add handling for missing event data types in the experim…
2b8cd6f 
…ental API (#41418)

* [winlogbeat] Add handling for missing event data types in the experimental API (#40684)

* Check type assertion result before using the result

* Update CHANGELOG.next.asciidoc

* Use sync.OnceValue to lazy init ansi decoder

* Move cached encoder out of function

* Add comment to clarify default cp

* Update strings_windows.go

(cherry picked from commit 36c3d5d)
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
6 tasks
marc-gr added a commit that referenced this pull request Nov 5, 2024
@mergify @marc-gr
[winlogbeat] Add handling for missing event data types in the experim…
b768b39 
…ental API (#41418) (#41512)

* [winlogbeat] Add handling for missing event data types in the experimental API (#40684)

* Check type assertion result before using the result

* Update CHANGELOG.next.asciidoc

* Use sync.OnceValue to lazy init ansi decoder

* Move cached encoder out of function

* Add comment to clarify default cp

* Update strings_windows.go

(cherry picked from commit 36c3d5d)

Co-authored-by: Marc Guasch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@faec faec faec approved these changes

@intxgo intxgo intxgo approved these changes

@leehinman leehinman leehinman approved these changes

Assignees

@marc-gr marc-gr

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Winlogbeat: Experimental API support missing event data types
8 participants
@marc-gr @elasticmachine @andrewkroh @faec @intxgo @leehinman @ycombinator @pierrehilbert