Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Compare previous/current cluster state in the elasticsearch.shard metricset #40731

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

consulthys
Copy link
Contributor

This PR adds logic to compare the cluster state UUID between two runs and only send elasticsearch.shard documents if the cluster state has effectively changed. Doing so not only helps save bandwidth as well as ES resources (CPU, thread pools, etc) but also prevents the indexing_failed counter from increasing upon each HTTP 409.

Proposed commit message

Only index elasticsearch.shard documents if there are changes in the cluster state

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None, as no new shard documents are indexed unless the cluster state changes.

Related issues

Closes #39058

@consulthys consulthys requested a review from a team as a code owner September 10, 2024 12:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2024
@consulthys consulthys requested a review from pickypg September 10, 2024 12:43
Copy link
Contributor

mergify bot commented Sep 10, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @consulthys? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@consulthys consulthys added Team:Monitoring Stack Monitoring team release-note:fix The content should be included as a fix labels Sep 10, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement release-note:fix The content should be included as a fix Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Improve the elasticsearch module when used for Stack Monitoring
2 participants