Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid gotestsum import in libbeat es output #39835

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 7, 2024

Proposed commit message

gotestsum is being imported causing downstream apps to include it in the dependency tree.
Drop the import and use the client logger.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

gotestsum is being imported causing downstream apps to include it
in the dependency tree.
Drop the import and use the client logger.
@kruskall kruskall added the bug label Jun 7, 2024
@kruskall kruskall requested a review from a team as a code owner June 7, 2024 21:55
@kruskall kruskall requested review from fearful-symmetry and faec June 7, 2024 21:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 7, 2024
Copy link
Contributor

mergify bot commented Jun 7, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2024
@cmacknz cmacknz added the backport-v8.14.0 Automated backport with mergify label Jun 10, 2024
@cmacknz
Copy link
Member

cmacknz commented Jun 10, 2024

Thanks, definitely wrong.

@kruskall kruskall merged commit a2ab85d into elastic:main Jun 10, 2024
106 checks passed
@kruskall kruskall deleted the fix/avoid-gotestsum-import branch June 10, 2024 15:20
mergify bot pushed a commit that referenced this pull request Jun 10, 2024
gotestsum is being imported causing downstream apps to include it
in the dependency tree.
Drop the import and use the client logger.

(cherry picked from commit a2ab85d)

# Conflicts:
#	libbeat/outputs/elasticsearch/client.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants