-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang-crossbuild: Fix a vulnerability CVE-2022-24765 #34242
Conversation
hence this should help to avoid issues
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
…lity-announced/\#cve-2022-24765 since the docker image does not contain the /home then let's use / instead
dev-tools/mage/crossbuild.go
Outdated
@@ -333,6 +333,8 @@ func (b GolangCrossBuilder) Build() error { | |||
"--env", "MAGEFILE_VERBOSE="+verbose, | |||
"--env", "MAGEFILE_TIMEOUT="+EnvOr("MAGEFILE_TIMEOUT", ""), | |||
"--env", fmt.Sprintf("SNAPSHOT=%v", Snapshot), | |||
// See https://github.com/elastic/golang-crossbuild/issues/232 | |||
"--env", "GIT_CEILING_DIRECTORIES=\/"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"--env", "GIT_CEILING_DIRECTORIES=\/"), | |
"--env", "GIT_CEILING_DIRECTORIES=//"), |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
What does this PR do?
The announcement for CVE-2022-24765 recommends setting GIT_CEILING_DIRECTORIES to prevent out-of-bounds config access.
Why is it important?
Otherwise, it will fail with:
How to test this PR locally
Related issues