Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timeout status code in trace produced by self instrumentation #15117

Closed

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 3, 2025

Motivation/summary

WIP

TODO: implement the actual fix. Although trace transaction result is HTTP 5xx, it is not the 5xx returned by timeout middleware, as timeout middleware should return 503. It is actually the one from writeStreamResult processStreamError default HTTP 500:

errID := request.IDResponseErrorsInternal

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Fixes #14232

Copy link
Contributor

mergify bot commented Jan 3, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 3, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 3, 2025
@carsonip carsonip added backport-8.17 Automated backport with mergify backport-8.16 Automated backport with mergify labels Jan 3, 2025
@1pkg
Copy link
Member

1pkg commented Jan 4, 2025

closing this in favor of #15123 and #15122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intake v2 request timeout causes inconsistent log and self-instrumented trace
2 participants