Fix incorrect timeout status code in trace produced by self instrumentation #15117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
WIP
TODO: implement the actual fix. Although trace transaction result is HTTP 5xx, it is not the 5xx returned by timeout middleware, as timeout middleware should return 503. It is actually the one from
writeStreamResult
processStreamError
default HTTP 500:apm-server/internal/beater/api/intake/handler.go
Line 148 in 52849ff
Checklist
For functional changes, consider:
How to test these changes
Related issues
Fixes #14232