Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable TBS in benchmark terraform #14985

Merged
merged 14 commits into from
Dec 17, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Dec 17, 2024

Motivation/summary

Update testing/benchmark terraform and github workflow to add an option to enable TBS.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Run testing/benchmark terraform locally

Related issues

Related to #11346 . This should enable reproducible benchmarks on cloud.

Meta issue #14931

Copy link
Contributor

mergify bot commented Dec 17, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Dec 17, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 17, 2024
@carsonip carsonip marked this pull request as ready for review December 17, 2024 15:26
@carsonip carsonip requested a review from a team as a code owner December 17, 2024 15:26
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding the storage limit setting too?

@carsonip
Copy link
Member Author

Do you think it's worth adding the storage limit setting too?

I don't want to further complicate the github workflow UI, so keeping it fixed for github workflow use case. But it will be configurable when running terraform locally.

@carsonip carsonip requested a review from marclop December 17, 2024 15:42
marclop
marclop previously approved these changes Dec 17, 2024
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may also need to add a GitHub action variable for the storage value, but not blocking.

@carsonip
Copy link
Member Author

We may also need to add a GitHub action variable for the storage value, but not blocking.

Done.

Also added GOBENCH tag to tell if TBS is enabled

@carsonip carsonip requested a review from marclop December 17, 2024 16:00
@carsonip carsonip merged commit 258f5df into elastic:main Dec 17, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
Update testing/benchmark terraform and github workflow to add an option to enable TBS.

(cherry picked from commit 258f5df)
mergify bot added a commit that referenced this pull request Dec 17, 2024
Update testing/benchmark terraform and github workflow to add an option to enable TBS.

(cherry picked from commit 258f5df)

Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Dec 19, 2024
Record TBS lsm size and vlog size in benchtest to facilitate TBS improvements when running benchmarks using gh actions following #14985
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
Record TBS lsm size and vlog size in benchtest to facilitate TBS improvements when running benchmarks using gh actions following #14985

(cherry picked from commit 1ea7439)
mergify bot added a commit that referenced this pull request Dec 19, 2024
Record TBS lsm size and vlog size in benchtest to facilitate TBS improvements when running benchmarks using gh actions following #14985

(cherry picked from commit 1ea7439)

Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Dec 19, 2024
A regression from #14985 causing nightly benchmark to fail.
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
A regression from #14985 causing nightly benchmark to fail.

(cherry picked from commit 7c1b706)
mergify bot added a commit that referenced this pull request Dec 19, 2024
…#15004)

A regression from #14985 causing nightly benchmark to fail.

(cherry picked from commit 7c1b706)

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants