-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enable TBS in benchmark terraform #14985
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
|
testing/infra/terraform/modules/ec_deployment/scripts/enable_features.tftpl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth adding the storage limit setting too?
I don't want to further complicate the github workflow UI, so keeping it fixed for github workflow use case. But it will be configurable when running terraform locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We may also need to add a GitHub action variable for the storage value, but not blocking.
Done. Also added GOBENCH tag to tell if TBS is enabled |
Update testing/benchmark terraform and github workflow to add an option to enable TBS. (cherry picked from commit 258f5df)
Update testing/benchmark terraform and github workflow to add an option to enable TBS. (cherry picked from commit 258f5df) Co-authored-by: Carson Ip <[email protected]>
Record TBS lsm size and vlog size in benchtest to facilitate TBS improvements when running benchmarks using gh actions following #14985
Record TBS lsm size and vlog size in benchtest to facilitate TBS improvements when running benchmarks using gh actions following #14985 (cherry picked from commit 1ea7439) Co-authored-by: Carson Ip <[email protected]>
A regression from #14985 causing nightly benchmark to fail.
…#15004) A regression from #14985 causing nightly benchmark to fail. (cherry picked from commit 7c1b706) Co-authored-by: Carson Ip <[email protected]>
Motivation/summary
Update testing/benchmark terraform and github workflow to add an option to enable TBS.
Checklist
For functional changes, consider:
How to test these changes
Run testing/benchmark terraform locally
Related issues
Related to #11346 . This should enable reproducible benchmarks on cloud.
Meta issue #14931