Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog for 8.15.4 #14561

Merged
merged 4 commits into from
Nov 11, 2024
Merged

changelog for 8.15.4 #14561

merged 4 commits into from
Nov 11, 2024

Conversation

inge4pres
Copy link
Contributor

Changelog entry for upcoming 8.15.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 6, 2024
@inge4pres inge4pres changed the title WIP: changelog for 8.15.4 changelog for 8.15.4 Nov 8, 2024
@inge4pres inge4pres marked this pull request as ready for review November 8, 2024 15:34
@inge4pres inge4pres requested a review from a team as a code owner November 8, 2024 15:34
carsonip
carsonip reviewed Nov 8, 2024
View reviewed changes
changelogs/8.15.asciidoc Outdated
[float]
==== Bug fixes

- Rollover for all APM data streams is now executing correctly in Elasticsearch 8.15.4, fixing a https://www.elastic.co/guide/en/observability/current/apm-known-issues.html#_upgrading_to_v8_15_x_may_cause_ingestion_to_fail[known issue] present in all patch versions of this minor release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: I don't see any changes in apm-server repo related to this. Does the fix sit in ES apm-data plugin? If so, is it possible to attach the PR here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahsivjar told me the fix is entirely in ES, and I also had a doubt if the apm-server changelog should have this entry.
WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would make sense to have it in the apm-server changelog. The users might not really care which exact component, but rather that it was a problem in apm-server data ingestion that was fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on adding PR link. Also, should we be more explicit for the "all patch versions of this minor release" but? We can say "for 8.15.0 to 8.15.3 versions"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll add.
What link should be used, the ES PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think elastic/elasticsearch#116219 should be good enough.

1pkg
1pkg previously approved these changes Nov 8, 2024
View reviewed changes
lahsivjar
lahsivjar reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A minor comment

changelogs/8.15.asciidoc Outdated
[float]
==== Bug fixes

- Rollover for all APM data streams is now executing correctly in Elasticsearch 8.15.4, fixing a https://www.elastic.co/guide/en/observability/current/apm-known-issues.html#_upgrading_to_v8_15_x_may_cause_ingestion_to_fail[known issue] present in all patch versions of this minor release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on adding PR link. Also, should we be more explicit for the "all patch versions of this minor release" but? We can say "for 8.15.0 to 8.15.3 versions"?

lahsivjar
lahsivjar approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inge4pres inge4pres enabled auto-merge (squash) November 11, 2024 14:55
inge4pres and others added 4 commits November 11, 2024 16:12
@inge4pres
WIP: changelog for 8.15.4
d54d301 
Signed-off-by: inge4pres <[email protected]>
@inge4pres
Update 8.15.asciidoc
640bbed 
Signed-off-by: inge4pres <[email protected]>
@inge4pres
amend copy: list affected versions
78d647f 
Signed-off-by: inge4pres <[email protected]>
@inge4pres
add PR link
529d695 
Signed-off-by: inge4pres <[email protected]>
@inge4pres inge4pres merged commit ae0e4db into elastic:main Nov 11, 2024
7 checks passed
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
@inge4pres @mergify
changelog for 8.15.4 (#14561)
68aa2f5 
Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit ae0e4db)
@mergify mergify bot mentioned this pull request Nov 11, 2024
Merged
@inge4pres inge4pres deleted the changelog/8.15.4 branch November 11, 2024 15:38
mergify bot added a commit that referenced this pull request Nov 11, 2024
@mergify @inge4pres
changelog for 8.15.4 (#14561) (#14605)
7ccb181 
Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit ae0e4db)

Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

@lahsivjar lahsivjar lahsivjar approved these changes

@1pkg 1pkg 1pkg left review comments

@carsonip carsonip Awaiting requested review from carsonip

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inge4pres @lahsivjar @simitt @carsonip @1pkg