Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(8.x): bump beats to latest version #14470

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Oct 29, 2024

Motivation/summary

Revert beats bump revert but pin the ristretto version to keep using badger v2 (since the version is binary compatible)

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #11546
Closes #14297

pin ristretto to a version before generics was added to not break binary
compatibility
@kruskall kruskall requested a review from a team as a code owner October 29, 2024 13:53
@@ -177,3 +173,5 @@ replace (
// command line flags and conflicting with command line flags added by libbeat.
github.com/golang/glog => ./internal/glog
)

replace github.com/dgraph-io/ristretto v0.1.2-0.20240116140435-c67e07994f91 => github.com/dgraph-io/ristretto v0.2.0
Copy link
Member

@1pkg 1pkg Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment above on why we are doing thing?

@kruskall kruskall merged commit 2c52e11 into elastic:8.x Oct 31, 2024
11 checks passed
@kruskall kruskall deleted the bump/beats-8.x branch October 31, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants