Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] PGO: optimize collected profile file size (backport #14256) #14267

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 4, 2024

Motivation/summary

This PR addresses the issue #14255, by applying some quick optimization to how CPU profiles are collected for PGO. It reduces total collection time to 5% and strips unnecessary data such as tags and profile memory addresses that don't affect PGO.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

#14255
#13884


This is an automatic backport of pull request #14256 done by [Mergify](https://mergify.com).

(cherry picked from commit 3833927)

# Conflicts:
#	.github/workflows/benchmarks.yml
#	systemtest/benchtest/profiles.go
#	testing/benchmark/Makefile
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 4, 2024
@mergify mergify bot requested a review from a team as a code owner October 4, 2024 16:58
Copy link
Contributor Author

mergify bot commented Oct 4, 2024

Cherry-pick of 3833927 has failed:

On branch mergify/bp/8.x/pr-14256
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 3833927f8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/benchmarks.yml
	both modified:   systemtest/benchtest/profiles.go
	both modified:   testing/benchmark/Makefile

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned 1pkg Oct 4, 2024
@1pkg 1pkg closed this Oct 4, 2024
@1pkg 1pkg deleted the mergify/bp/8.x/pr-14256 branch October 4, 2024 16:59
@1pkg 1pkg restored the mergify/bp/8.x/pr-14256 branch October 11, 2024 15:53
@1pkg 1pkg reopened this Oct 11, 2024
Copy link
Contributor Author

mergify bot commented Oct 11, 2024

This pull request is now in conflicts. Could you fix it @mergify[bot]? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-14256 upstream/mergify/bp/8.x/pr-14256
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-14256

@mergify mergify bot merged commit 7097284 into 8.x Oct 11, 2024
13 checks passed
@mergify mergify bot deleted the mergify/bp/8.x/pr-14256 branch October 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant