-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform: enable build tag (backport #13841) #14240
Conversation
(cherry picked from commit b4c79b3) # Conflicts: # testing/infra/terraform/modules/tags/output.tf
Cherry-pick of b4c79b3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 thanks
Oh, the cherry picked commit is not signed 😢 Fixing it |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 183a008 |
@endorama mergify is special 😉 |
Motivation/summary
I'd like to honour the CI details so we can tag any cloud resources with the Build ID or so, this will help to identify if the resources were created when running the terraform locally or in the CI.
For instance, currently
Then when https://github.com/elastic/apm-aws-lambda/actions/workflows/smoke-tests.yml runs I wanna see
Or something similar
Checklist
For functional changes, consider:
How to test these changes
Related issues
This is an automatic backport of pull request #13841 done by [Mergify](https://mergify.com).