Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BenchmarkPublisher mock ES returning extra document responses #13991

Closed
wants to merge 1 commit into from

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Sep 4, 2024

Motivation/summary

Discovered by #13973

No change in behavior. Just fixing in case anyone reuses the code for mock ES usage.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner September 4, 2024 11:55
@carsonip carsonip closed this Sep 4, 2024
Copy link
Contributor

mergify bot commented Sep 4, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 4, 2024
@carsonip
Copy link
Member Author

carsonip commented Sep 4, 2024

Closing as scanner.Scan is already called in require.True(b, scanner.Scan()). There is nothing to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant