-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for fallback to ILM if DSL not present #13918
Conversation
This pull request is now in conflicts. Could you fix it @lahsivjar? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog target branch should be main, with backport-8.15 label
Simply change target branch to main creates a mess. At this point i think it is just easier to manually rebase onto main, then change target branch to main. |
It is not in this case because the fix for main has been reverted and it might require a different changelog. Anyway, this PR needs a bit more updates after the recent changes in the fix. Will get this cleaned up. |
I believe the 8.15.asciidoc needs to be updated in both main branch and 8.15 branch, hence targeting main and backporting to 8.15. It has nothing to do with a separate bugfix for main. |
1175732
to
3b4a9c2
Compare
Co-authored-by: Carson Ip <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🙏🏼
(cherry picked from commit de642ac)
(cherry picked from commit de642ac) Co-authored-by: Vishal Raj <[email protected]>
Motivation/summary
APM-Server switched from Index Lifecycle Management(ILM) to Datastream Lifecycle (DSL) in v8.15.0. This switch was done when we moved from APM integration (which used ILM) to APM-data plugin (which uses DSL) in ES for managing APM datastreams. As a result of the switch, any old datastreams created before the switch would be
Unmanaged
because the datastream will never be updated with the DSL lifecycle -- this has to be done manually by using the PUT API.Checklist
How to test these changes
Create a stack (ES, Kibana, APM-Server) with data-persistence enabled for ES using
8.14.3
version. We use the8.14.3
as that is the latest available version which uses APM integration package and thus configures ILM policies.Example docker-compose.yaml
Install the APM integration in the cluster.
Send some data, for example: by using apmsoak. Example command:
go run ./cmd/apmsoak/ run --file cmd/apmsoak/scenarios.yml --scenario apm-server --server-url http://localhost:8200
Assert that the APM indices created are managed by ILM, for example: by running
GET /_data_stream/traces-apm-default
to check for trace indicesBuild an Elasticsearch docker image using the branch in this PR:
./gradlew buildAarch64DockerImage
Update the versions used in the stack created in step 1 to
8.16.0-SNAPSHOT
, for ES use the docker image built in step 5Send some more data as we did in step 3
Assert that all the APM indices are still managed by ILM
Rollover the datastream
Assert that all the APM indices, including the one created using rollover in step 9, are still managed by ILM
Also, test if the setup works by itself i.e. if a cluster is created using the latest version (with the changes in the PR) then it works as expected and the created APM indices in this case are managed by DSL (datastream lifecycle).
NOTE: Any indices created when APM is on version
8.15.0
and datastream created before8.15.0
i.e. with ILM, will remainUnmanaged
even after this fix. To fix them, we would need to explicitly update them OR use the PUT API on datastream to set DSL.Related issues
8.15.0
are without lifecycle policies #13898Unmanaged
on upgrade elasticsearch#112137