feat: bump go to 1.23.0 #13880
Merged
feat: bump go to 1.23.0 #13880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use go get to update go versions in go.mod drop go requirement from readme the go requirement in the readme is less relevant since the introduction of go toolchains. It's also not accurate becaure we're requiring a patch version.
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
endorama
approved these changes
Aug 14, 2024
| @@ -17,7 +17,7 @@ To get started with APM, see our [Quick start guide](https://www.elastic.co/guid | |||
|
|
|||
| ### Requirements | |||
|
|
|||
| * [Go][golang-download] 1.22.x | |||
| * [Go][golang-download] | |||
There was a problem hiding this comment.
What do you think about mentioning the .go-version file here without an explicit reference to the version?
Suggested change
| * [Go][golang-download] | |
| * [Go][golang-download] (prefer installing the version specified in `.go-version`) |
There was a problem hiding this comment.
I want to get rid of .go-version tbh and use go.mod as the source of truth 😅
1pkg
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
use go get to update go versions in go.mod
drop go requirement from readme
the go requirement in the readme is less relevant since the introduction of go toolchains.
It's also not accurate becaure we're requiring a patch version.
Checklist
For functional changes, consider:
How to test these changes
Related issues