Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger Deprecation #13809

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Jaeger Deprecation #13809

merged 4 commits into from
Aug 14, 2024

Conversation

rubvs
Copy link
Contributor

@rubvs rubvs commented Jul 31, 2024 •
edited
Loading

Related to Issue 11671

  • Add jaeger deprecation info to logger when server starts up
  • Add warning the first an endpoint is hit
  • Updated docs and changelog

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024

This pull request does not have a backport label. Could you fix it @rubvs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 31, 2024
@rubvs rubvs force-pushed the deprecate-jaeger branch from d852894 to 129d85d Compare July 31, 2024 18:46
@rubvs rubvs requested review from endorama, inge4pres and kruskall July 31, 2024 20:32
@kruskall
Copy link
Member

kruskall commented Aug 2, 2024

Also, the PR seems ready for review, feel free to un-draft it 😄

@rubvs rubvs marked this pull request as ready for review August 7, 2024 23:44
@rubvs rubvs requested a review from a team as a code owner August 7, 2024 23:44
@rubvs rubvs force-pushed the deprecate-jaeger branch from a35bd7e to 3b97b50 Compare August 12, 2024 21:45
axw
axw reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of comments.

changelogs/head.asciidoc Outdated Show resolved Hide resolved
internal/beater/jaeger/grpc.go Outdated Show resolved Hide resolved
axw
axw approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rubvs rubvs force-pushed the deprecate-jaeger branch from 5a15008 to 340e14b Compare August 14, 2024 22:37
@rubvs rubvs merged commit 106a52c into elastic:main Aug 14, 2024
14 checks passed
@rubvs rubvs deleted the deprecate-jaeger branch August 14, 2024 23:02
@kruskall kruskall mentioned this pull request Oct 21, 2024
Closed
11 tasks
@marclop marclop self-assigned this Oct 25, 2024
@marclop
Copy link
Contributor

marclop commented Oct 25, 2024

Tested locally with latest 8.16:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall left review comments

@simitt simitt simitt left review comments

@1pkg 1pkg 1pkg approved these changes

@axw axw axw approved these changes

@endorama endorama Awaiting requested review from endorama

@inge4pres inge4pres Awaiting requested review from inge4pres

Assignees

@marclop marclop

Labels
backport-skip Skip notification from the automated backport with mergify test-plan-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rubvs @kruskall @marclop @axw @simitt @1pkg