Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/elastic/go-docappender/v2 from 2.1.4 to 2.2.0 #13574

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2024

Bumps github.com/elastic/go-docappender/v2 from 2.1.4 to 2.2.0.

Release notes

Sourced from github.com/elastic/go-docappender/v2's releases.

v2.2.0

What's Changed

New Contributors

Full Changelog: elastic/go-docappender@v2.1.4...v2.2.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/elastic/go-docappender/v2](https://github.com/elastic/go-docappender) from 2.1.4 to 2.2.0.
- [Release notes](https://github.com/elastic/go-docappender/releases)
- [Commits](elastic/go-docappender@v2.1.4...v2.2.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/go-docappender/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 3, 2024 18:04
@dependabot dependabot bot added dependency go Pull requests that update Go code labels Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request does not have a backport label. Could you fix it @dependabot[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 3, 2024
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes need changelogs

@inge4pres
Copy link
Contributor

some changes need changelogs

Do you mean that we should include a summary of the changes between v2.1.4 and v2.2.0?

Or simply add an entry to the changelog to signal the upgrade?

@inge4pres
Copy link
Contributor

@carsonip I don't see dependencies being upgraded on a minor included in other previous changelogs 🤔
What should we add in this PR?

@inge4pres inge4pres requested a review from carsonip July 10, 2024 09:22
@carsonip
Copy link
Member

carsonip commented Jul 10, 2024

@carsonip I don't see dependencies being upgraded on a minor included in other previous changelogs 🤔
What should we add in this PR?

Changes that are user facing should be mentioned in changelog. For this particular bump, I believe bulk_indexer: track all response status codes is relevant.

Or simply add an entry to the changelog to signal the upgrade?

We need to describe each change in go-docappender in a separate line of changelog in apm-server, if they are relevant to users. Imagine go-docappender and apm-data as parts of apm-server.

@kruskall
Copy link
Member

I've opened #13712 to take care of the issue

@kruskall kruskall closed this Jul 17, 2024
@kruskall kruskall reopened this Jul 17, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@kruskall kruskall enabled auto-merge (squash) July 17, 2024 10:36
@kruskall kruskall merged commit 9e50a32 into main Jul 17, 2024
10 checks passed
@kruskall kruskall deleted the dependabot/go_modules/github.com/elastic/go-docappender/v2-2.2.0 branch July 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify dependency go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants