-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/elastic/go-docappender/v2 from 2.1.4 to 2.2.0 #13574
build(deps): bump github.com/elastic/go-docappender/v2 from 2.1.4 to 2.2.0 #13574
Conversation
Bumps [github.com/elastic/go-docappender/v2](https://github.com/elastic/go-docappender) from 2.1.4 to 2.2.0. - [Release notes](https://github.com/elastic/go-docappender/releases) - [Commits](elastic/go-docappender@v2.1.4...v2.2.0) --- updated-dependencies: - dependency-name: github.com/elastic/go-docappender/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This pull request does not have a backport label. Could you fix it @dependabot[bot]? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes need changelogs
Do you mean that we should include a summary of the changes between v2.1.4 and v2.2.0? Or simply add an entry to the changelog to signal the upgrade? |
@carsonip I don't see dependencies being upgraded on a minor included in other previous changelogs 🤔 |
Changes that are user facing should be mentioned in changelog. For this particular bump, I believe bulk_indexer: track all response status codes is relevant.
We need to describe each change in go-docappender in a separate line of changelog in apm-server, if they are relevant to users. Imagine go-docappender and apm-data as parts of apm-server. |
I've opened #13712 to take care of the issue |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/elastic/go-docappender/v2 from 2.1.4 to 2.2.0.
Release notes
Sourced from github.com/elastic/go-docappender/v2's releases.
Commits
0c05046
add otel tracing support (#182)044911f
build(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9 (#183)a1b25d4
bulk_indexer: track all response status codes (#177)0530a0f
fix: update CODEOWNERS (#181)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)