Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove fleetctl cmd #13440

Merged
merged 1 commit into from
Jun 19, 2024
Merged

refactor: remove fleetctl cmd #13440

merged 1 commit into from
Jun 19, 2024

Conversation

kruskall
Copy link
Member

Motivation/summary

We are no longer using fleet for systemtests or local dev so the utility is unused.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@kruskall
refactor: remove fleetctl cmd
0843a4a 
We are no longer using fleet for systemtests or local dev so the utility is unused.
@kruskall kruskall requested a review from a team as a code owner June 19, 2024 01:46
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 19, 2024
endorama
endorama approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question but can be addressed in a follow-up. Looks good to me

systemtest/cmd/fleetctl/main.go
"github.com/spf13/cobra"
"gopkg.in/yaml.v3"

"github.com/elastic/apm-server/systemtest/fleettest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fleettest still used? Should we look into removing it too? I noticed that part of it has been introduced with cmd/fleetctl in #8778

(Maybe we should try with deadcode?

Copy link
Member Author

@kruskall kruskall Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still used unfortunately :(

I think we can still remove some methods

@kruskall kruskall merged commit cc43962 into elastic:main Jun 19, 2024
14 checks passed
@kruskall kruskall deleted the remove/fleetctl branch June 19, 2024 10:24
endorama added a commit to endorama/apm-server that referenced this pull request Jun 19, 2024
@endorama
reintroduce flettctl
0209bcf 
removed in elastic#13440 from systemtests
but still can be useful for development or manual testing purposes
@carsonip carsonip mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @endorama